Comments on: Loghetti Beta - An Apache Log Filter http://www.protocolostomy.com/2008/03/13/loghetti-beta-an-apache-log-filter/ Made with only the finest 1's and 0's Fri, 21 Nov 2008 14:44:45 +0000 http://wordpress.org/?v=2.6 By: Kent Johnson http://www.protocolostomy.com/2008/03/13/loghetti-beta-an-apache-log-filter/#comment-192 Kent Johnson Fri, 14 Mar 2008 00:21:09 +0000 http://www.protocolostomy.com/2008/03/13/loghetti-beta-an-apache-log-filter/#comment-192 Thanks, this looks like it will be handy. You could make the expensive properties lazy fairly easily, e.g. with this recipe: http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/363602 Perhaps you want to group the 'laziness' so asking for e.g. year will also populate month, day, etc. Other small optimizations in ApacheLogLine.__init__(): - Only call self.request_line.split(' ') once, e.g. self.http_method, self.url, self.http_vers = self.request_line.split(' ') - Move self.rex to a class attribute, there is no need to compile and store this for every line! The output is IMO more readable if ApacheLogLine.__str__() uses ' '.join() rather than ','.join(). Thanks, this looks like it will be handy. You could make the expensive properties lazy fairly easily, e.g. with this recipe:
http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/363602

Perhaps you want to group the ‘laziness’ so asking for e.g. year will also populate month, day, etc.

Other small optimizations in ApacheLogLine.__init__():
- Only call self.request_line.split(’ ‘) once, e.g.
self.http_method, self.url, self.http_vers = self.request_line.split(’ ‘)
- Move self.rex to a class attribute, there is no need to compile and store this for every line!

The output is IMO more readable if ApacheLogLine.__str__() uses ‘ ‘.join() rather than ‘,’.join().

]]>